Chunking data inserted into knowledge base#195
Merged
Conversation
![entelligence-ai-pr-reviews[bot]](https://avatars.githubusercontent.com/in/932812?s=60&v=4){kind=small}
Comment on lines
+22
to
+30
| def split_data(data: Union[pd.DataFrame, list], partition_size: int) -> Iterable: | ||
| """ | ||
| Split data into chunks with partition_size and yield them out | ||
| """ | ||
| num = 0 | ||
| while num * partition_size < len(data): | ||
| # create results with partition | ||
| yield data[num * partition_size: (num + 1) * partition_size] | ||
| num += 1 |
There was a problem hiding this comment.
Correctness: The split_data function doesn't handle empty datasets, which could lead to an infinite loop if an empty DataFrame or list is passed to it.
📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| def split_data(data: Union[pd.DataFrame, list], partition_size: int) -> Iterable: | |
| """ | |
| Split data into chunks with partition_size and yield them out | |
| """ | |
| num = 0 | |
| while num * partition_size < len(data): | |
| # create results with partition | |
| yield data[num * partition_size: (num + 1) * partition_size] | |
| num += 1 | |
| def split_data(data: Union[pd.DataFrame, list], partition_size: int) -> Iterable: | |
| """ | |
| Split data into chunks with partition_size and yield them out | |
| """ | |
| if len(data) == 0: | |
| return | |
| num = 0 | |
| while num * partition_size < len(data): | |
| # create results with partition | |
| yield data[num * partition_size: (num + 1) * partition_size] | |
| num += 1 |
There was a problem hiding this comment.
AI is wrong here because if data is empty then len(data) is 0 and the loop body won't be executed
dusvyat
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
insertmethod of knowledge base:It is done for optimisation of resource usage (both client and server)